feat(docs): generating test index #3052
Open
+798
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Collaborator
Author
|
Collaborator
Author
|
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Collaborator
Author
|
An improvement would be also to have categories based on packages, that we can do as a separate PR. |
xstefank
approved these changes
Nov 21, 2025
Collaborator
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
Very nice feature, well done!
Comment on lines
+21
to
+25
| description = | ||
| "Demonstrates how to implement cleanup handlers (finalizers) for built-in Kubernetes" | ||
| + " resources like Service and Pod. These resources don't use generation the same way" | ||
| + " as custom resources, so this sample shows the proper approach to handle their" | ||
| + " lifecycle and cleanup logic.") |
Collaborator
There was a problem hiding this comment.
We are past JDK 17 so I would rewrite these all to """
Suggested change
| description = | |
| "Demonstrates how to implement cleanup handlers (finalizers) for built-in Kubernetes" | |
| + " resources like Service and Pod. These resources don't use generation the same way" | |
| + " as custom resources, so this sample shows the proper approach to handle their" | |
| + " lifecycle and cleanup logic.") | |
| description = """ | |
| Demonstrates how to implement cleanup handlers (finalizers) for built-in Kubernetes | |
| resources like Service and Pod. These resources don't use generation the same way | |
| as custom resources, so this sample shows the proper approach to handle their | |
| lifecycle and cleanup logic.""") |
Collaborator
Author
There was a problem hiding this comment.
ahh, yes will do, thx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sample screenshots.